This revision was automatically updated to reflect the committed changes.
Closed by commit rC356848: [X86] Add BSR/BSF/BSWAP intrinsics to ia32intrin.h
to match gcc. (authored by ctopper, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59682?vs=192010&id=192017#toc
Repositor
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM - cheers
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59682/new/
https://reviews.llvm.org/D59682
___
cfe
craig.topper updated this revision to Diff 192010.
craig.topper added a comment.
Add doxygen comments. Check the zero_undef flag.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59682/new/
https://reviews.llvm.org/D59682
Files:
lib/Headers/ia32intrin.h
lib/Hea
RKSimon added inline comments.
Comment at: lib/Headers/ia32intrin.h:31
+static __inline__ int __attribute__((__always_inline__, __nodebug__))
+__bsfd(int __A) {
Ideally we'd have doxygen comments.
Comment at: test/CodeGen/bitscan-builtins.c:2
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
These are all implemented by icc as well.
I made bit_scan_forward/reverse forward to the __bsfd/__bsrq since we also have
__bsfq/__bsrq.
Note,
