[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Jordan Rupprecht via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC356614: [clang][OpenMP] Fix build when using libgomp (authored by rupprecht, committed by ). Changed prior to commit: https://reviews.llvm.org/D59609?vs=191567&id=191577#toc Repository: rC Clang CHA

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht added a comment. In D59609#1436975 , @lebedev.ri wrote: > Interesting. > What happens if libomp is not being built? > What happens if libomp is not present? I'm far from an omp expert (only running across this because some tests failed), but

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59609/new/ https://reviews.llvm.org/D59609 ___

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. If the compiler is built without OpenMP support -fopenmp is converted to -fopenmp=libgomp frontend option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59609/new/ https://reviews.llvm.org/D59609 ___

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a reviewer: ABataev. lebedev.ri added a comment. Interesting. What happens if libomp is not being built? What happens if libomp is not present? Or more generally, why does it even matter whether there is runtime or not, this only does paring+sema, no codegen/execution. Reposit

[PATCH] D59609: [clang][OpenMP] Fix build when using libgomp

2019-03-20 Thread Jordan Rupprecht via Phabricator via cfe-commits
rupprecht created this revision. rupprecht added a reviewer: lebedev.ri. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. rL356570 introduced a test which only passes with the default openmp library, libomp, and fails w