This revision was automatically updated to reflect the committed changes.
Closed by commit rC356947: AMDGPU: Add support for cross address space
synchronization scopes (clang) (authored by kzhuravl, committed by ).
Herald added a subscriber: ebevhan.
Herald added a project: clang.
Repository:
r
rampitec accepted this revision.
rampitec added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59494/new/
https://reviews.llvm.org/D59494
___
cfe-commits mailing list
cfe-commi
b-sumner added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7976
+
+Name = Twine(Twine(Name) + Twine("one-as")).str();
+ }
rampitec wrote:
> b-sumner wrote:
> > kzhuravl wrote:
> > > rampitec wrote:
> > > > I think subgroup is in the single addres
rampitec added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7976
+
+Name = Twine(Twine(Name) + Twine("one-as")).str();
+ }
b-sumner wrote:
> kzhuravl wrote:
> > rampitec wrote:
> > > I think subgroup is in the single address space even if sequenti
b-sumner added a comment.
Comment at: lib/CodeGen/TargetInfo.cpp:7976
+
+Name = Twine(Twine(Name) + Twine("one-as")).str();
+ }
kzhuravl wrote:
> rampitec wrote:
> > I think subgroup is in the single address space even if sequentially
> > consistent.
> I
kzhuravl updated this revision to Diff 191193.
kzhuravl marked an inline comment as done.
kzhuravl added a comment.
Address review feedback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59494/new/
https://reviews.llvm.org/D59494
Files:
lib/CodeGen/CGAtomic.cpp
lib/CodeGen/TargetIn
kzhuravl added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7976
+
+Name = Twine(Twine(Name) + Twine("one-as")).str();
+ }
rampitec wrote:
> I think subgroup is in the single address space even if sequentially
> consistent.
I have synced with @t-
rampitec added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:7973
+ if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) {
+if (Scope != SyncScope::OpenCLAllSVMDevices)
+ Name = Twine(Twine(Name) + Twine("-")).str();
if (!Name.empty()
kzhuravl created this revision.
kzhuravl added reviewers: b-sumner, rampitec, t-tye.
Herald added subscribers: jfb, tpr, dstuttard, yaxunl, wdng.
kzhuravl added a comment.
Backend change will be posted later today. I am currently working on adding
backend tests.
https://reviews.llvm.org/D59494
kzhuravl added a comment.
Backend change will be posted later today. I am currently working on adding
backend tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59494/new/
https://reviews.llvm.org/D59494
___
cfe-commits mailing list
cfe-
10 matches
Mail list logo
