This revision was automatically updated to reflect the committed changes.
Closed by commit rC356423: [X86] Add gcc rotate intrinsics to ia32intrin.h
(authored by ctopper, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59346?vs=190943&id=191189#toc
Repository:
rC Clang
CH
jyknight accepted this revision.
jyknight added a comment.
Looks good.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59346/new/
https://reviews.llvm.org/D59346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper updated this revision to Diff 190943.
craig.topper added a comment.
Add comments based on rnk's review
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59346/new/
https://reviews.llvm.org/D59346
Files:
lib/Headers/ia32intrin.h
test/CodeGen/rot-intr
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good to me. Let's wait for @jyknight though.
Comment at: lib/Headers/ia32intrin.h:120
+
+#ifndef _MSC_VER
+/* Select the correct function based on the size of long. */
--
craig.topper updated this revision to Diff 190568.
craig.topper added a comment.
Fix bad comment copy/paste
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59346/new/
https://reviews.llvm.org/D59346
Files:
lib/Headers/ia32intrin.h
test/CodeGen/rot-intrinsics.c
craig.topper updated this revision to Diff 190567.
craig.topper added a comment.
Add the test file
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59346/new/
https://reviews.llvm.org/D59346
Files:
lib/Headers/ia32intrin.h
test/CodeGen/rot-intrinsics.c
Index:
craig.topper created this revision.
craig.topper added reviewers: rnk, jyknight, RKSimon, spatel, erichkeane.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.
craig.topper updated this revision to Diff 190567.
craig.topper added a comment.
Add the test file
This is another at
