[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431302 , @arsenm wrote: > > ML workloads are extremely unlikely to use a call. We should have an > execution tests with noinline somewhere to stress this I compiled and ran a test with noinline function and I saw fu

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431284 , @yaxunl wrote: > In D59316#1431276 , @arsenm wrote: > > > In D59316#1431253 , @yaxunl wrote: > > > > > In D59316#1431238

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431276 , @arsenm wrote: > In D59316#1431253 , @yaxunl wrote: > > > In D59316#1431238 , @arsenm wrote: > > > > > In D59316#1429580

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431253 , @yaxunl wrote: > In D59316#1431238 , @arsenm wrote: > > > In D59316#1429580 , @yaxunl wrote: > > > > > Here we are looking at the

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431238 , @arsenm wrote: > In D59316#1429580 , @yaxunl wrote: > > > Here we are looking at the code which emulates a "linker" for HIP > > toolchain. The offloading action builder r

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1429580 , @yaxunl wrote: > Here we are looking at the code which emulates a "linker" for HIP toolchain. > The offloading action builder requests the offloading toolchain have a > linker, but amdgpu does not have a real l

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356277: [HIP-Clang] propagate -mllvm options to opt and llc (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D59316?vs=190474&id=190850#toc Repository: rC

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59316/new/ https://reviews.llvm.org/D59316 ___ cfe-c

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. Here we are looking at the code which emulates a "linker" for HIP toolchain. The offloading action builder requests the offloading toolchain have a linker, but amdgpu does not have a real linker (ISA level linker), so we have to emulate that. If we have an ISA level link

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1427996 , @ashi1 wrote: > Hi Matt, that solution will need refactoring and testing. Currently, > HIP-Clang is following the same link flow as HCC HCC is also an issue. I really want effort put into fixing this rather th

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

ashi1 added a comment. Hi Matt, that solution will need refactoring and testing. Currently, HIP-Clang is following the same link flow as HCC Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59316/new/ https://reviews.llvm.org/D59316 _

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. The real solution is to stop invoking these tools separately. clang -cc1 should be used for everything Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59316/new/ https://reviews.llvm.org/D59316 ___

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've updated the HIP ToolChain to pass OPT_mllvm options into OPT and LLC stages. Also added a lit test to verify its properly passed down. All check-clang tests p