[PATCH] D59282: [Parse] Parse '#pragma clang attribute' as an external-declaration

2019-03-13 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356075: [Parse] Parse '#pragma clang attribute' as an external-declaration (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D59282: [Parse] Parse '#pragma clang attribute' as an external-declaration

2019-03-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Parser/pragma-attribute-context.cpp:29 +struct InStruct { + // FIXME: This asserts in Objective-C++! + /

[PATCH] D59282: [Parse] Parse '#pragma clang attribute' as an external-declaration

2019-03-12 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, arphaman, rsmith. Herald added subscribers: dexonsmith, jkorous. Herald added a project: clang. Previously, we parsed it only in the top level, which excludes namespaces and `extern "C"` blocks. rdar://problem