[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

2019-03-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL355831: clang-format: distinguish ObjC call subexpressions after r355434 (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

2019-03-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. most of the cases that we were adding here were for a templated return types e.g. verifyFormat("[]() -> foo<5 + 2> { return {}; };"); verifyFormat("[]() -> foo<5 - 2> { return {}; };"); So we should probably have handle that "-> (return type)", where the retu

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

2019-03-11 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59210/new/ https://reviews.llvm.org/D59210 __

[PATCH] D59210: clang-format: distinguish ObjC call subexpressions after r355434

2019-03-11 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The revision r355434 had the unfortunate side-effect that it started to recognize certain ObjC expressions with a call subexpression followed by a `a->b` subexpression as C++ lambda expressions.