This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL361042: [analyzer] Remove the default value arg from
getChecker*Option (authored by Szelethus, committed by ).
Herald adde
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:148-150
+ assert(Ret &&
+ "This option should be either 'true' or 'false', and should've been "
+ "validated by CheckerRegisrty!");
NoQ wrote:
> Even though `
NoQ accepted this revision.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:148-150
+ assert(Ret &&
+ "This option should be either 'true' or 'false', and should've been "
+ "validated by CheckerRegisrty!");
Eve
Szelethus updated this revision to Diff 190996.
Szelethus added a comment.
Remove the default argument from the plugin, also add a test case for it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59195/new/
https://reviews.llvm.org/D59195
Files:
examples/StaticAnalyzer/OptionHandlingP
Szelethus updated this revision to Diff 190993.
Szelethus added a comment.
Rebase.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59195/new/
https://reviews.llvm.org/D59195
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cp
baloghadamsoftware accepted this revision.
baloghadamsoftware added a comment.
This is straightforward.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59195/new/
https://reviews.llvm.org/D59195
___
cfe-commits mailing
Szelethus created this revision.
Szelethus added reviewers: NoQ, baloghadamsoftware, xazax.hun, rnkovacs.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, Charusso, jdoerfert, gamesh411, dkrupp,
donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity.
Herald added a revi
