[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith closed this revision. dexonsmith added a comment. Committed in r355950. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59176/new/ https://reviews.llvm.org/D59176 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/lib/Frontend/FrontendActions.cpp:182 + CI.getFrontendOpts().BuildingImplicitModule && + CI.getLangOpts().isCompilingModule())); Consumers.push_back(CI.getPCHContainer

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith updated this revision to Diff 190203. dexonsmith added a comment. Updated the constructor call to `PCHGenerator` in `GenerateModuleAction::CreateASTConsumer` to use `BuildingImplicitModule` on its own. Checking where it's set (only in `compileModuleImpl`), it's exactly the condition

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith marked 2 inline comments as done. dexonsmith added a comment. In D59176#1424864 , @jordan_rose wrote: > This commit by itself doesn't change any behavior, right? Correct, it just exposes an option. Comment at: clang/lib/Fro

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

jordan_rose added a comment. This commit by itself doesn't change any behavior, right? Comment at: clang/lib/Frontend/FrontendActions.cpp:115 CI.getPreprocessorOpts().AllowPCHWithCompilerErrors, - FrontendOpts.IncludeTimestamps)); + FrontendOpts.IncludeTimestam

[PATCH] D59176: Modules: Add LangOptions::CacheGeneratedPCH

dexonsmith created this revision. dexonsmith added reviewers: bruno, rsmith, vsapsai, jordan_rose. Herald added a subscriber: jdoerfert. Add an option to cache the generated PCH in the ModuleCache when emitting it. This protects clients that build PCHs and read them in the same process, allowing