This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE355676: [clangd] Deduplicate Refs on the fly. (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D59092?vs=189825&id=189826#toc
Repository:
rCTE Clang Tools Extr
hokein updated this revision to Diff 189825.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59092/new/
https://reviews.llvm.org/D59092
Files:
clangd/index/Ref.cpp
cla
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Ref.cpp:44
RefSlab RefSlab::Builder::build() && {
// We can reuse the arena, as it only has unique strings and we need them
all.
-
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, ioeric,
ilya-biryukov.
Herald added a project: clang.
Currently, we only do deduplication when we flush final results. We may
have huge duplications (refs from headers) d
