This revision was automatically updated to reflect the committed changes.
Closed by commit rL355410: [HIP] Do not unbundle object files for -fno-gpu-rdc
(authored by yaxunl, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/Driver.cpp:2298
+/// Flag for -fgpu-rdc.
+bool Relocatable;
public:
ABataev wrote:
> Set the default initializer for the field
will do. thanks.
Repository:
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/Driver/Driver.cpp:2298
+/// Flag for -fgpu-rdc.
+bool Relocatable;
public:
Set the default initializer for the fie
tra added a subscriber: ABataev.
tra added a comment.
The change looks OK as far as regular CUDA is concerned.
That said, I'm not quite familiar with the use of bundling/unbundling actions
and you should probably get someone who uses/depends on them to take a look. I
think OpenMP uses them. Perh
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added a subscriber: jdoerfert.
Herald added a project: clang.
When -fno-gpu-rdc is set, device code is compiled, linked, and assembled into
fat binary
and embedded as string in object files. The object files are normal object
fil
