[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rL355090: Moved Ref into its own header and implementation file (authored by gribozavr, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Hera

[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + ioeric wrote: > License? Added. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 188724. gribozavr marked 2 inline comments as done. gribozavr added a comment. Added a missing include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files: clang

[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 188723. gribozavr marked an inline comment as done. gribozavr added a comment. Added a license header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58778/new/ https://reviews.llvm.org/D58778 Files: clang-

[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.cpp:1 +#include "Ref.h" + License? Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:14 #include "CodeCompletionStrings.h" +#include "ExpectedTypes.h" #

[PATCH] D58778: Moved Ref into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58778 Files: clang-tools-extra/clangd/AST.h