This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE355088: Moved Symbol into its own header and
implementation file (authored by gribozavr, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58774?vs=188714&id=188715#toc
Repository:
gribozavr updated this revision to Diff 188714.
gribozavr added a comment.
Herald added a subscriber: mgrang.
Also moved the SymbolSlab implementation into Symbol.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58774/new/
https://reviews.llvm.org
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/Index.cpp:19
-llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, Symbol::SymbolFlag F) {
- if (F == Symbol::None)
-return OS << "None";
- std::string S;
- if (F & Symbol::Deprecated)
-S += "de
gribozavr added a comment.
Moved SymbolSlab as well, PTAL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58774/new/
https://reviews.llvm.org/D58774
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
gribozavr updated this revision to Diff 188712.
gribozavr added a comment.
Moving SymbolSlab as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58774/new/
https://reviews.llvm.org/D58774
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang
ioeric added a comment.
The design of Symbol and SymbolSlab are closely related. I would suggest
putting them close together in the same library.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58774/new/
https://reviews.llvm.org/D58774
_
gribozavr created this revision.
gribozavr added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous,
mgorny.
Herald added a project: clang.
gribozavr added a parent revision: D58773: Moved SymbolOrigin into its own
header and implementation file.
Re
