[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355086: Moved SymbolOrigin into its own header and implementation file (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D58773?vs=188703&id=188709#toc Reposit

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

2019-02-28 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. In D58773#1413486 , @gribozavr wrote: > SymbolOrigin is used by itself, for example, in CodeComplete.h to define > `struct CodeCompletion`. Fair enou

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr added a comment. SymbolOrigin is used by itself, for example, in CodeComplete.h to define `struct CodeCompletion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58773/new/ https://reviews.llvm.org/D58773 __

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

2019-02-28 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. I'm not sure if SymbolOrigin is interesting enough to be its own library. It's usually only used along with Symbol. Maybe we could pull a library Symbol.h instead and put SymbolOrigin by Symbol? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D58773: Moved SymbolOrigin into its own header and implementation file

2019-02-28 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. gribozavr added a reviewer: ioeric. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58773 Files: clang-tools-extra/clangd/CMak