This revision was automatically updated to reflect the committed changes.
Closed by commit rL355076: [clang-tidy] misc-string-integer-assignment: fix
false positive (authored by courbet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
courbet added a comment.
Thanks !
> is there a bug or similar? If yes please mention it somewhere in the summary
> or so and close it :)
Yes, PR27723. Done.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58606/new/
https://reviews.llvm.org/D58606
alexfh accepted this revision.
alexfh added a comment.
LG. Thanks for improving this check!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58606/new/
https://reviews.llvm.org/D58606
___
cfe-commits maili
JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
LGTM.
is there a bug or similar? If yes please mention it somewhere in the summary or
so and close it :)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://review
courbet updated this revision to Diff 188318.
courbet added a comment.
- add more tests
- Traverse using decls.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58606/new/
https://reviews.llvm.org/D58606
Files:
clang-tidy/bugprone/StringIntegerAssig
xazax.hun added a comment.
The change looks good but it would be great to have a regression test as well.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58606/new/
https://reviews.llvm.org/D58606
___
cfe
courbet created this revision.
courbet added reviewers: xazax.hun, alexfh.
Herald added subscribers: cfe-commits, rnkovacs.
Herald added a project: clang.
using CodePoint = uint32_t;
CodePoint cp;
casic_string s;
s += cp;
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D58606
Fil
