This revision was automatically updated to reflect the committed changes.
Closed by commit rL355493: [clangd] Add Source to clangd::Diagnostic. (authored
by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACT
hokein updated this revision to Diff 189455.
hokein added a comment.
Don't emit the source to LSP level (as this is a UI change as least in vscode)
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58600/new/
https://reviews.llvm.org/D58600
Files:
cl
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58600/new/
https://reviews.llvm.org/D58600
hokein added a comment.
add @kadircet as a reviewer, since @ilya-biryukov is OOO.
Comment at: clangd/ClangdUnit.cpp:380
if (Preamble)
Diags.insert(Diags.begin(), Preamble->Diags.begin(),
Preamble->Diags.end());
return ParsedAST(std::move(Preamble), std::move(Clang),
hokein updated this revision to Diff 189285.
hokein marked 6 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58600/new/
https://reviews.llvm.org/D58600
Files:
clangd/ClangdUnit.cpp
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.cpp:380
if (Preamble)
Diags.insert(Diags.begin(), Preamble->Diags.begin(),
Preamble->Diags.end());
return ParsedAST(std::move(Preamble), std::move(Clang), std::move(Action),
Preamble d
jkorous added inline comments.
Comment at: clangd/Diagnostics.cpp:381
LastDiag = Diag();
+LastDiag->ID = Info.getID();
FillDiagBase(*LastDiag);
Nit - is this really intended to be part of this patch?
Comment at: clangd/Diagnostics
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric.
Herald added a project: clang.
Set "clang", "clang-tidy" as the source to the diagnostics, so that
client can distinguish diagnostics from clang-tidy.
Rep
