[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

This revision was automatically updated to reflect the committed changes. Closed by commit rL355282: [clang] [ToolChains/NetBSD] Support relative libc++ header path (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. This will make life much more easier now with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58592/new/ https://reviews.llvm.org/D58592 __

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny updated this revision to Diff 188083. mgorny added a comment. Shamelessly increased overhead by checking one more path as requested by Kamil. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58592/new/ https://reviews.llvm.org/D58592 Files: clang/lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

joerg added a comment. I'm not in favor of this. It adds overhead for the system compiler and generally makes the logic more complicated. This seems to be another hack around the fact that the driver has no clear notion of "use system runtime" vs "use custom runtime". Repository: rC Clang

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; mgorny wrote: > krytarowski wrote: > > mgorny wrote: > > > krytarowski wrote: > > > > I

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > mgorny wrote: > > krytarowski w

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; mgorny wrote: > krytarowski wrote: > > I propose to go for: > > > > `getDriver().SysRoo

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > I propose to go for: > > `getD

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

krytarowski added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; I propose to go for: `getDriver().SysRoot + "/usr/include/c++/v1",` with a fallback for

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, chandlerc, eugenis. Herald added a reviewer: EricWF. Herald added a project: clang. Support locating the libc++ header files relatively to the clang executable, in addition to the default system path. This is meant to cover