[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added a comment. In D58537#1476570 , @tstellar wrote: > Can you test D61054 ? I will do it ASAP, but I am currently having problems with my build system. I guess it is OK to proceed with this change. I will se

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added a comment. Can you test D61054 ? Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_W

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/inc

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION lib${LLV

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1474824 , @smeenai wrote: > @tstellar ping. Someone appears to be running into this on the CMake mailing > list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Sorry, I missed this. I will take a look.

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar ping. Someone appears to be running into this on the CMake mailing list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 __

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

vzakhari added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/inc

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rL355253: lib/Header: Simplify CMakeLists.txt (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1415534 , @smeenai wrote: > @tstellar are you planning to land this soon? It'll conflict with D58791 > , but I'm not planning to land that for > another few days, so I can rebase on top

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai added a comment. @tstellar are you planning to land this soon? It'll conflict with D58791 , but I'm not planning to land that for another few days, so I can rebase on top of this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188749. tstellar added a comment. Fix an issue with the generated arm headers that I discovered after doing some more testing. Also, remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ ht

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added a comment. LGTM, thanks! Comment at: clang/lib/Headers/CMakeLists.txt:136 list(APPEND out_files ${dst}) + # The list function only updates out_files in the current scope. We need + # call set in order to also update the variab

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1411657 , @tstellar wrote: > Use macros instead of functions. I mean "Use functions instead of macros." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https:/

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188500. tstellar added a comment. Use macros instead of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 Files: clang/lib/Headers/CMakeLists.txt Index: c

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

smeenai accepted this revision. smeenai added reviewers: beanz, phosek. smeenai added a comment. This revision is now accepted and ready to land. LGTM, though I generally prefer functions to macros. Comment at: clang/lib/Headers/CMakeLists.txt:127 -# Generate arm_neon.h -clan

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar created this revision. tstellar added reviewers: chandlerc, smeenai, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace cut and pasted code with cmake macros and reduce the number of install commands. This fixes an issue where the headers were being in