[PATCH] D58509: [CodeGen] Fix string literal address space casting.

2019-02-21 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC354610: [CodeGen] Fix string literal address space casting. (authored by hliao, committed by ). Herald added a subscriber: ebevhan. Changed prior to commit: https://reviews.llvm.org/D58509?vs=187797&id=

[PATCH] D58509: [CodeGen] Fix string literal address space casting.

2019-02-21 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58509/new/ https://reviews.llvm.org/D58509 __

[PATCH] D58509: [CodeGen] Fix string literal address space casting.

2019-02-21 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added a reviewer: yaxunl. Herald added subscribers: cfe-commits, jvesely. Herald added a project: clang. - If a string literal is reused directly, need to add necessary address space casting if the target requires that. Repository: rG LLVM Github Monorepo h