[PATCH] D58447: [clangd] Fix a crash in Selection

2019-02-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL354507: [clangd] Fix a crash in Selection (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D58447: [clangd] Fix a crash in Selection

2019-02-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 ___

[PATCH] D58447: [clangd] Fix a crash in Selection

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 187569. ilya-biryukov added a comment. - Fix a syntax error in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58447/new/ https://reviews.llvm.org/D58447 Files: clang-tools-extra/clangd/Selectio

[PATCH] D58447: [clangd] Fix a crash in Selection

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. The assertion checking that the range of the node is a token range does not hold in case of "split" tokens, e.g. bet