[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL354505: [clangd] Store index in '.clangd/index' instead of '.clangd-index' (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D58440?vs=187627&id=187629#toc Repos

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 187627. ilya-biryukov added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update .gitignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.l

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDirectory, ".clangd-index/"); +llvm::sys::path::append(CDBDirectory, ".clangd", "

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 187622. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Remove trailing slash from the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58440/new/ https://reviews.llvm.o

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp:75 llvm::SmallString<128> CDBDirectory(Directory); -llvm::sys::path::append(CDBDire

[PATCH] D58440: [clangd] Store index in '.clangd/index' instead of '.clangd-index'

2019-02-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. To take up the .clangd folder for other potential uses in the future. Repository: rG LLVM Github Monorepo https