MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:249
+ Identifier->ColumnWidth += Question->ColumnWidth;
+ Identifier->Type = Identifier->Type;
+ Tokens.erase(Tokens.end() - 1);
RKSimon added inline comments.
Comment at: lib/Format/FormatTokenLexer.cpp:249
+ Identifier->ColumnWidth += Question->ColumnWidth;
+ Identifier->Type = Identifier->Type;
+ Tokens.erase(Tokens.end() - 1);
@MyDeveloperDay Should this be
```
Identifier->Type = Qu
thakis added inline comments.
Comment at: docs/ReleaseNotes.rst:169
+- Add language support for clang-formatting C# files
+- Add Microsoft coding style to encapsulate default C# formatting style
Shouldn't this be in 'clang-format', not in 'AST Matchers'?
Repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC356662: [clang-format] Add basic support for formatting C#
files (authored by paulhoad, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58404?vs=191654&id=191669#toc
Repository:
rC
MyDeveloperDay added inline comments.
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:19
+
+class FormatTestCSharp : public ::testing::Test {
+protected:
klimek wrote:
> If everything's static, you don't need a test fixture at all, you can just
> make it
MyDeveloperDay updated this revision to Diff 191654.
MyDeveloperDay marked 3 inline comments as done.
MyDeveloperDay added a comment.
Address comment nits
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58404/new/
https://reviews.llvm.org/D58404
Files:
clang/docs/ClangFormat.rst
clan
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG. This looks pretty sharp (scnr).
Comment at: clang/lib/Format/FormatTokenLexer.cpp:177
+if (Dollar->TokenText == "$") {
+ // this looks like $@"a" so we need
MyDeveloperDay updated this revision to Diff 191649.
MyDeveloperDay added a comment.
Addressing Review Comments
- Remove all non Format only code (i.e. changes to clang/Basic and clang/Lexer
to support verbatim interpolated strings C# 6)
- For the most part the need to for them is removed by mer
MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added inline comments.
Comment at: include/clang/Basic/TokenKinds.h:80
K == tok::utf8_string_literal || K == tok::utf16_string_literal ||
- K == tok::utf32_string_literal;
}
klimek
klimek added inline comments.
Comment at: include/clang/Basic/TokenKinds.h:80
K == tok::utf8_string_literal || K == tok::utf16_string_literal ||
- K == tok::utf32_string_literal;
}
This change looks pretty good, minus the changes outside Format
MyDeveloperDay updated this revision to Diff 190737.
MyDeveloperDay added a comment.
Remove non related clang-format changes
run git clang-format
Add a Microsoft style (trying to match most closely the more traditional
Microsoft style used for C#)
This will allow, CSharp to be added to the confi
MyDeveloperDay updated this revision to Diff 188239.
MyDeveloperDay added a subscriber: llvm-commits.
MyDeveloperDay added a comment.
Fix a crash running clang-format over large C# code base
Add support for C# Null Coalescing
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58404/new/
http
MyDeveloperDay updated this revision to Diff 187969.
MyDeveloperDay added a comment.
Increase C# formatting capabilities
- don't split regions markers across lines
- lexer support for verbatim string literals
- support for interpolated string literals (C#6)
- support for interpolated verbatim st
MyDeveloperDay added a comment.
Note to self...Underdevelopment:
- adding support for => (JSBigArrow) for C# Lambas
- adding support for $"liternal {string} with arguments"
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58404/new/
https://reviews.llvm.org/D58404
_
MyDeveloperDay updated this revision to Diff 187748.
MyDeveloperDay added a comment.
Add to release notes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58404/new/
https://reviews.llvm.org/D58404
Files:
docs/ClangFormat.rst
docs/ClangFormatStyleOptions.rst
docs/ReleaseNotes.rst
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: djasper, klimek, krasimir, benhamilton,
JonasToth.
MyDeveloperDay added a project: clang.
Herald added subscribers: jdoerfert, mgorny.
This revision adds basic support for formatting C# files with clang-format, I
know the barr
16 matches
Mail list logo
