[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

2019-02-19 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC354351: Remove extraneous space in MSVC-style diagnostic output (authored by hans, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D58377?vs=187320&id=18

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

2019-02-19 Thread Nico Weber via Phabricator via cfe-commits
thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. wht CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58377/new/ https://reviews.llvm.org/D58377 ___ cfe-commits mailing list cfe-commit

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

2019-02-19 Thread Hans Wennborg via Phabricator via cfe-commits
hans updated this revision to Diff 187320. hans added a comment. Output a char instead of a one-character string. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58377/new/ https://reviews.llvm.org/D58377 Files: clang/lib/Frontend/TextDiagnostic.cpp clang/test/Misc/diag-format.c In

[PATCH] D58377: Remove extraneous space in MSVC-style diagnostic output

2019-02-19 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. hans added a reviewer: thakis. Herald added a subscriber: jdoerfert. There was an extra space between the file location and the diagnostic message: /tmp/a.c(1,12): warning: unused parameter 'unused' the tests didn't catch this due to FileCheck not running in --stri