[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added a comment. In D58368#1406490 , @NoQ wrote: > Address comments. > > @Charusso: I agreed not to rush for D58367 > and implemented an old-style visitor here instead :) Thanks you! I wanted to accept it when

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354641: [analyzer] MIGChecker: Improve intermediate diagnostic notes. (authored by dergachev, committed by ). Herald added

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ updated this revision to Diff 187873. NoQ marked an inline comment as done. NoQ added a comment. Address comments. @Charusso: I agreed not to rush for D58367 and implemented an old-style visitor here instead :) CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ marked 3 inline comments as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:47 REGISTER_TRAIT_WITH_PROGRAMSTATE(ReleasedParameter, bool); Charusso wrote: > `;` is not necessary. Addressed in the earlier patch

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ marked 3 inline comments as done. NoQ added a comment. Thx! Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ostream OS(Str); +OS << "Deallocating object passed through parameter '" << PVD->getName() + << '\''; --

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:47 REGISTER_TRAIT_WITH_PROGRAMSTATE(ReleasedParameter, bool); `;` is not necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://revie

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

Charusso added a reviewer: Charusso. Charusso requested changes to this revision. Charusso added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:113 + }); + C.addTransition(C.getState()->set(true), T);

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me. I have some a minor diagnostic wording suggestion in line. Comment at: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp:109 +llvm::raw_svector_ost

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ updated this revision to Diff 187502. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58368/new/ https://reviews.llvm.org/D58368 Files: clang/lib/StaticAnalyzer/Checkers/MIGChecker.cpp clang/test/Analysis/mig.mm Index: clang/test/Analysis/mig.mm

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This adds two visitors to the checker: - `trackExpressionValue()` in