[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 196180. leonardchan added a subscriber: mcgrathr. leonardchan added a comment. Herald added a subscriber: hiraditya. Uploading my latest version of this patch and reporting some results. Will proceed with formatting and cleanup and ask for official review

[PATCH] D58321: [WIP] Support for relative vtables

riccibruno added a comment. I think that you need to update the serialization code in `Serialization/ASTReaderDecl.cpp` and `Serialization/ASTWriterDecl.cpp` to account for the new flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ ht

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188987. leonardchan added a comment. - Remove `hasHiddenLTOVisibility` from `CXXRecordDecl` and rename the flag to `-frelative-c++-abi-vtables` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ http

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h clang/include/clang/Bas

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188973. leonardchan added a comment. Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. Update to current working version without needing LTO Repository: rG LLVM Githu

[PATCH] D58321: [WIP] Support for relative vtables

rjmccall added inline comments. Comment at: clang/include/clang/Driver/Options.td:1250 + Group, Flags<[CC1Option]>, + HelpText<"Use the unstable C++ class ABI for classes with hidden LTO visibility">; def flto_jobs_EQ : Joined<["-"], "flto-jobs=">, Please mak

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan added a comment. In D58321#1407362 , @pcc wrote: > Can we start with a patch that just exposes a flag that enables the relative > ABI unconditionally, and remove all the platform ABI compatibility stuff? Done. Removed the checks requiring LT

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188256. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h clang/include/clang/Bas

[PATCH] D58321: [WIP] Support for relative vtables

pcc added a comment. Can we start with a patch that just exposes a flag that enables the relative ABI unconditionally, and remove all the platform ABI compatibility stuff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.ll

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan created this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This is a revisit to D20749 which introduces a flag that enables the relative ABI described in https://bugs.llvm.org/show_bug.cgi?id=26723. Repo