This revision was automatically updated to reflect the committed changes.
Closed by commit rC354141: [clang] Add build and install targets for clang
libraries (authored by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58269?vs=186957&id=187019#toc
Repository:
rC
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58269/new/
https://reviews.llvm.org/D58269
___
smeenai added a comment.
A couple of things I noticed while writing this patch:
- clang guards its install target creation with `CMAKE_CONFIGURATION_TYPES`,
whereas LLVM uses `LLVM_ENABLE_IDE`. Should clang be switched over to be
consistent with LLVM?
- I realize we create the `install-clang-li
smeenai updated this revision to Diff 186957.
smeenai added a comment.
Fix condition
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58269/new/
https://reviews.llvm.org/D58269
Files:
clang/CMakeLists.txt
clang/cmake/modules/AddClang.cmake
Inde
smeenai created this revision.
smeenai added reviewers: beanz, phosek.
Herald added a subscriber: mgorny.
Herald added a project: clang.
This is modeled after the existing llvm-libraries target. It's a
convenient way to include all clang libraries in a distribution.
This differs slightly from the
