This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL354486: [OPENMP] Delay emission of the asm target-specific
error messages. (authored by ABataev, committed by ).
Herald ad
kkwli0 added a comment.
The change looks okay to me.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58243/new/
https://reviews.llvm.org/D58243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
tra added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:256-263
// If we're compiling CUDA file and function attributes indicate that it's
not
// for this compilation side, skip all the checks.
if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:256-263
// If we're compiling CUDA file and function attributes indicate that it's
not
// for this compilation side, skip all the checks.
if (!DeclAttrsMatchCUD
tra added inline comments.
Comment at: lib/Sema/SemaStmtAsm.cpp:256-263
// If we're compiling CUDA file and function attributes indicate that it's
not
// for this compilation side, skip all the checks.
if (!DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl())) {
ABataev added a comment.
Ping!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58243/new/
https://reviews.llvm.org/D58243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
ABataev created this revision.
ABataev added a reviewer: rjmccall.
Herald added subscribers: jdoerfert, guansong.
Herald added a project: clang.
Added the ability to emit target-specific builtin assembler error
messages only in case if the function is really is going to be emitted
for the device.
