This revision was automatically updated to reflect the committed changes.
Closed by commit rL354262: [clang][Index] Fix usage of
IndexImplicitInstantiation (authored by kadircet, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES
kadircet updated this revision to Diff 187014.
kadircet added a comment.
- Get rid of redundant test
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58189/new/
https://reviews.llvm.org/D58189
Files:
lib/Index/IndexTypeSourceInfo.cpp
test/Index/Core/index-sourc
kadircet added inline comments.
Comment at: unittests/Index/IndexTests.cpp:40
+Position P;
+P.Line = static_cast(SM.getLineNumber(FID, Offset)) - 1;
+P.Column = SM.getColumnNumber(FID, Offset) - 1;
ilya-biryukov wrote:
> Why do we need to `static_cast
kadircet updated this revision to Diff 186995.
kadircet marked 6 inline comments as done.
kadircet added a comment.
Address comments
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58189/new/
https://reviews.llvm.org/D58189
Files:
lib/Index/IndexTypeSourceInfo.c
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58189/new/
https://reviews.llvm.org/D58189
___
ilya-biryukov added inline comments.
Comment at: unittests/Index/IndexTests.cpp:30
+struct Position {
+ size_t Line;
NIT: put all of the decls of a file into an anonymous namespace
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
ilya-biryukov added a comment.
Only have a few NITs, will dig deeper into the change tomorrow.
Added @arphaman too as an owner of the index library. Alex, feel free to
reassign if you're the wrong person to take a look at this
Comment at: unittests/Index/IndexTests.cpp:31
+str
kadircet created this revision.
Herald added subscribers: cfe-commits, jdoerfert, arphaman.
Herald added a project: clang.
Indexing context was skipping explicit template instantiations as well.
This patch makes sure it only skips implicit ones.
Repository:
rC Clang
https://reviews.llvm.org/D
