[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. I agree with the comments. I think we should strive to be strictly conforming. I make that argument all the time for libc++, so I'll be consistent :-). https://reviews.llvm.org/D58289 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58149/n

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

jfb added a comment. In D58149#1397532 , @rsmith wrote: > In D58149#1397499 , @ldionne wrote: > > > In D58149#1397390 , @jfb wrote: > > > > > In D58149#1397382

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

rsmith added a comment. In D58149#1397499 , @ldionne wrote: > In D58149#1397390 , @jfb wrote: > > > In D58149#1397382 , @efriedma > > wrote: > > > > > Formally, I don't thin

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. In D58149#1397390 , @jfb wrote: > In D58149#1397382 , @efriedma wrote: > > > Formally, I don't think C11 is a normative reference for C++11 or C++14, > > only C++17 (see [intro.refs] in the

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

jfb added a comment. In D58149#1397382 , @efriedma wrote: > Formally, I don't think C11 is a normative reference for C++11 or C++14, only > C++17 (see [intro.refs] in the standard). Right, this was changed in wg21.link/p0063r3 That being said, we *can*

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

efriedma added a comment. Formally, I don't think C11 is a normative reference for C++11 or C++14, only C++17 (see [intro.refs] in the standard). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58149/new/ https://reviews.llvm.org/D58149

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rC353970: [clang] Make sure C99/C11 features in are provided in C++11 (authored by ldionne, committed by ). Changed prior to commit: https://reviews.llvm.org/D58149?vs=186544&id=186703#toc Repo

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne added a comment. I'll ship this. @eli.friedman I think this is your playground -- if you want any changes to happen post-review, please LMK and I will gladly cooperate. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58149/new/ https://reviews.llvm.org/D58

[PATCH] D58149: [clang] Make sure C99/C11 features in are provided in C++11

ldionne created this revision. ldionne added reviewers: jfb, eli.friedman. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. Previously, those #defines were only provided in C or when GNU extensions were enabled. We need those #defines in C++11 and above, t