[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.llvm.org/D58147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Well, it won't have a guarantee that it won't see unused annotations, but alright, I'm fine with this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.ll

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. In D58147#1398094 , @rjmccall wrote: > Okay. Is it acceptable for the annotation to simply disappear in this case? > I don't really understand the purposes of annotations well enough to judge. Looks like it is acceptable. The

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

rjmccall added a comment. Okay. Is it acceptable for the annotation to simply disappear in this case? I don't really understand the purposes of annotations well enough to judge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.llvm.org/D58147 __

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. I've checked and seems like other places where we `EmitAnnotationCall` should be safe. We do that for globals, function parameters, fields (`FieldDecl`) and early return isn't applicable in those cases. We can do that for any expressions with `__builtin_annotation` but

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai created this revision. vsapsai added a reviewer: rjmccall. Herald added subscribers: dexonsmith, jkorous, aprantl. When we have an annotated local variable after a function returns, we generate IR that fails verification with the error > Instruction referencing instruction not embedded in