This revision was automatically updated to reflect the committed changes.
Closed by commit rC353840: [Sema] Fix a crash in access checking for deduction
guides (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58111?vs=186447&id=186450#toc
Repository:
ilya-biryukov updated this revision to Diff 186447.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58111/new/
https://reviews.llvm.org/D58111
Files:
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3178
auto *TD = DG->getDeducedTemplate();
- if (AS != TD->getAccess()) {
+ bool InSameScope = TD->getDec
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added a project: clang.
See the added test for a repro.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D58111
Files:
clang/lib/Sema/SemaDeclCXX.cpp
clang/test/Sema/crash-deduction-guide-a
