This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE354949: [clangd] Library dependencies in XPC (authored by
jkorous, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58089?vs=186369&id=188494#toc
Repository:
rCTE Clang Tools Extr
jkorous accepted this revision.
jkorous added a comment.
This revision is now accepted and ready to land.
Reconsidered - let's fix the build first and I can finish my patch tomorrow.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58089/new/
https://r
jkorous requested changes to this revision.
jkorous added a comment.
This revision now requires changes to proceed.
Hi @comex, I totally missed this! Thanks for the patch.
I am not entirely happy about this dependency though. I am trying to split off
the only parts of clangDaemon that XpcTranspor
comex added a comment.
Ping.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58089/new/
https://reviews.llvm.org/D58089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
comex added a comment.
Oh, forgot to mention in the initial submission: I don't have commit access so
I'll need someone else to commit this.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58089/new/
https://reviews.llvm.org/D58089
___
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58089/new/
https://reviews.llvm.org/D58089
___
comex created this revision.
comex added reviewers: jkorous, phosek.
Herald added subscribers: cfe-commits, kadircet, arphaman, ioeric,
ilya-biryukov, mgorny.
Herald added a project: clang.
Fixes build in BUILD_SHARED_LIBS mode.
Removes the "DEPENDS clangdXpcJsonConversions" line as LINK_LIBS al
