NoQ added a comment.
> The analyzer test change maybe indicates we could simplify the analyzer code
> a little with this fix? Apparently a hack was added to support lvalues in
> initializers in r315750, but I'm not really familiar with the relevant code.
Nope, unfortunately, not much can be sim
This revision was automatically updated to reflect the committed changes.
efriedma marked an inline comment as done.
Closed by commit rC353762: [Sema] Mark GNU compound literal array init as an
rvalue. (authored by efriedma, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D580
efriedma marked 2 inline comments as done.
efriedma added inline comments.
Comment at: lib/Sema/SemaInit.cpp:172-173
+ E = PE->getSubExpr();
+else if (UnaryOperator *UO = dyn_cast(E))
+ E = UO->getSubExpr();
+else if (GenericSelectionExpr *GSE = dyn_cast(E))
---
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaInit.cpp:172-173
+ E = PE->getSubExpr();
+else if (UnaryOperator *UO = dyn_cast(E))
+ E = UO->getSubExpr();
+else if (GenericSe
efriedma created this revision.
efriedma added a reviewer: rsmith.
Herald added a project: clang.
Basically the same issue as string init, except it didn't really have any
visible consequences before I removed the implicit lvalue-to-rvalue conversion
from CodeGen.
While I'm here, a couple minor
