[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-13 Thread Balogh , Ádám via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353943: [Analyzer] Crash fix for FindLastStoreBRVisitor (authored by baloghadamsoftware, committed by ). Changed prior to commit: https://reviews.llvm.org/D58067?vs=186470&id=186625#toc Repository: r

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-12 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 186470. baloghadamsoftware marked 3 inline comments as not done. baloghadamsoftware added a comment. Herald added a subscriber: jdoerfert. Function renamed, comment updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58067/new/ https:/

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, right, indeed, thanks, nice! We should eventually remove `operator==()` from the `SVal` class because it doesn't do anything you'd possibly imagine it to do. However we do need to come up with

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. I tried very hard to create a test case where we are crashing on a true positive but I did not succeed. I am not sure whether it is possible so fixing the false positive in `CallAndMessageUnInitRefArg` also

[PATCH] D58067: [Analyzer] Crash fix for FindLastStoreBRVisitor

2019-02-11 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, dcoughlin. baloghadamsoftware added a project: clang. Herald added subscribers: gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet. This patch is a fix for bug 40625