This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE353708: [clangd] Prefer location from codegen files when
merging symbols. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58037?vs=186245&id=186251#toc
Reposit
ioeric updated this revision to Diff 186245.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Address review comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58037/new/
https://reviews.llvm.org/D58037
Files:
clangd/XRefs.
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/XRefs.cpp:261
}
+// Returns the preferred location between an AST location and an index
location.
+SymbolLocation getPreferredLocation(const Lo
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
For example, if an index symbol has location in a .proto file and an AST symbol
has location in a generated
