[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. This was submitted again with the fix. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

rnk added a comment. I reverted this in rC353893 because it was still causing test failures. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 _

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

arsenm added a comment. I think this breaks the attributes already listed in the functions on the IR since -mattr overrides those. I think we need to stop using subtarget features to communicate this Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ http

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC353880: [HIP] Handle compile -m options and propagate into LLC (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D57977?vs=186528&id=186534#toc Repository:

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM. Please make sure to update your commit message as your patch processes all m options now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 added a comment. Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910 So that the default is set. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Is it still code object v2 by default? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186528. ashi1 added a comment. I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you add some tests? Preferably with -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 _

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 updated this revision to Diff 186519. ashi1 added a comment. Herald added a subscriber: jdoerfert. Changed patch to us handleTargetFeatures, to consume all -m options passed into clang. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 File

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. https://github.com/llvm-mirror/clang/blob/master/lib/Driver/ToolChains/AMDGPU.cpp#L52 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57977/new/ https://reviews.llvm.org/D57977 ___ cfe-commits

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

kzhuravl added a comment. Can you handle all features as follows instead of checking a particular option? ‘handleTargetFeaturesGroup( Args, Features, options::OPT_m_amdgpu_Features_Group);’ ? There is code in AMDGPU tool chain you can use as a reference. Repository: rC Clang CHANGES SINC

[PATCH] D57977: [HIP] compile option code-object-v3 propagate to llc

ashi1 created this revision. ashi1 added reviewers: yaxunl, kzhuravl. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows the compile option -mcode-object-v3 to be set by default, unless the -mno-code-object-v3 is added to the compile options. Repository: