This revision was automatically updated to reflect the committed changes.
Closed by commit rC361314: [Driver] Verify GCCInstallation is valid (authored
by nickdesaulniers, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57930?vs=200580&id=200586#toc
Repository:
rC Clang
C
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Thanks for picking this up and finishing it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57930/new/
https://reviews.llvm.org/D57930
_
nickdesaulniers updated this revision to Diff 200580.
nickdesaulniers added a comment.
Herald added a subscriber: ormris.
- add unit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57930/new/
https://reviews.llvm.org/D57930
Files:
clang/lib/D
nickdesaulniers added a comment.
@danielmentz thanks for this patch! Some teammates are running into issues that
would be fixed by this patch.
I think @srhines is asking for a test similar to what I wrote in r344941
(https://github.com/llvm/llvm-project/commit/11dadac247e677de124328077d080fe086
danielmentz marked an inline comment as done.
danielmentz added inline comments.
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260
if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") !=
StringRef::npos)
// With devtoolset on RHEL, we want to
tstellar added inline comments.
Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260
if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") !=
StringRef::npos)
// With devtoolset on RHEL, we want to add a bin directory that is relative
srhines added a comment.
Would it be reasonable to have a test for this with perhaps an invalid GCC
installation? There is some mock GCC/sysroot testing in
https://github.com/llvm/llvm-project/blob/master/clang/test/Driver/android-gcc-toolchain.c
and
https://github.com/llvm/llvm-project/blob/m
danielmentz created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Values returned by GCCInstallation.getParentLibPath() and
GCCInstallation.getTriple() are not valid unless
GCCInstallation.isValid() returns true. This has previously been
ignored, and the for
