This revision was automatically updated to reflect the committed changes.
Closed by commit rC354267: [ASTImporter] Find previous friend function template
(authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57910?vs=187212&id=187228#toc
Repository:
rC Clan
martong updated this revision to Diff 187212.
martong added a comment.
Rebase to master
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57910/new/
https://reviews.llvm.org/D57910
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittes
martong updated this revision to Diff 187211.
martong added a comment.
- Add FIXME
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57910/new/
https://reviews.llvm.org/D57910
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AS
a_sidorin accepted this revision.
a_sidorin added a comment.
Hi Gabor,
This patch LGTM with a minor nit.
Comment at: unittests/AST/ASTImporterTest.cpp:5109
+ // Currently chains of FunctionTemplateDecls are not implemented
+ //EXPECT_EQ(Imported->getPreviousDecl(), Friend);
+
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM, I just ran `check-lldb` and I don't see any regressions.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57910/new/
https://reviews.llvm.org/D57910
martong added a comment.
Ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57910/new/
https://reviews.llvm.org/D57910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
martong created this revision.
martong added reviewers: a_sidorin, shafik.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a project: clang.
Repository:
rC Clang
https://reviews.llvm.org/D57910
Files:
lib/AST/AST
