This revision was automatically updated to reflect the committed changes.
martong marked an inline comment as done.
Closed by commit rC353504: [AST] Fix structural inequivalence of operators
(authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57902?vs=185793
martong marked 2 inline comments as done.
martong added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:251
+
+TEST_F(StructuralEquivalenceFunctionTest, CtorVsDtor) {
+ auto t = makeDecls(
shafik wrote:
> Curious, is this test just for c
shafik added inline comments.
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:251
+
+TEST_F(StructuralEquivalenceFunctionTest, CtorVsDtor) {
+ auto t = makeDecls(
Curious, is this test just for completeness or is this somehow related to the
overloaded o
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57902/new/
https://reviews.llvm.org/D57902
_
martong created this revision.
martong added reviewers: shafik, a_sidorin, aaron.ballman.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a project: clang.
Operators kind was not checked, so we reported e.g. op- to be equal with op+
Repository:
rC Cl
