[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

This revision was automatically updated to reflect the committed changes. Closed by commit rL353421: [clangd] Fix an assertion failure in Selection. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein updated this revision to Diff 185771. hokein added a comment. Remove an unexpected change. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57879/new/ https://reviews.llvm.org/D57879 Files: clangd/Selection.cpp unittests/clangd/SelectionTes

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein updated this revision to Diff 185770. hokein added a comment. Add reproduce testcase. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57879/new/ https://reviews.llvm.org/D57879 Files: clangd/Selection.cpp unittests/clangd/SelectionTests.cp

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. In D57879#1388789 , @ilya-biryukov wrote: > Repro: > > template > struct Foo {}; > > template class /*cursor here*/U> > struct Foo*>

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

ilya-biryukov added a comment. Repro: template struct Foo {}; template class /*cursor here*/U> struct Foo*> {}; I'm not sure how easy is that, but this should probably be fixed in the `RecursiveASTVisitor<>`. There's really no point in calling `TraverseDecl(null)` Repository: r

[PATCH] D57879: [clangd] Fix an assertion failure in Selection.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, kristof.beyls, javed.absar. Herald added a project: clang. The assertion is triggered when the Decl is null. I didn't have a small reproduce tes