compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Basic/Targets/AMDGPU.cpp:263
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
+#if _WIN32
+ WCharType = UnsignedShort;
---
b-sumner added a comment.
Maybe there are already other types like this, but it saddens me that an
offline compiled code object could potentially not work properly if the
application is using any of these types. Or should the runtime try to detect a
problem using argument metadata?
CHANGES S
yaxunl created this revision.
yaxunl added a reviewer: b-sumner.
Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng,
jvesely, kzhuravl.
In MSVC wchar_t and wint_t are unsigned short. There is static_assert in MSVC
headers checking that.
Since HIP and OpenCL share the sam
