This revision was automatically updated to reflect the committed changes.
Closed by commit rL354120: [ASTImporter] Import every Decl in lambda record
(authored by martong, committed by ).
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.
Changed prior to commit:
h
shafik added a comment.
LGTM although I wish we had more lambda tests.
Please remember to check the LLDB build bots when landing the patch.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57740/new/
https://reviews.llvm.org/D57740
__
gamesh411 updated this revision to Diff 185509.
gamesh411 added a comment.
Remove unnecessary ToTU variable from test case.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57740/new/
https://reviews.llvm.org/D57740
Files:
lib/AST/ASTImporter.cpp
unittests/AST/
balazske added inline comments.
Comment at: unittests/AST/ASTImporterTest.cpp:2432
+ EXPECT_TRUE(ToD);
+ Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl();
+ CXXRecordDecl *LambdaRec =
Actually the `ToTU` is not needed, this line can be removed.
R
gamesh411 created this revision.
gamesh411 added reviewers: a.sidorin, shafik.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Previously only the fields were imported. Now every Decl is imported.
This way the destructor decl is not missing after import.
Patch by balazske (
