This revision was automatically updated to reflect the committed changes.
Closed by commit rL353983: [WebAssembly] Bulk memory intrinsics and builtins
(authored by tlively, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57736?vs=186504&id=186740#toc
Repository:
rL LLVM
C
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13477
+if (!SegArg->isIntegerConstantExpr(SegConst, getContext()))
+ llvm_unreachable("Constant arg isn't actually
tlively updated this revision to Diff 186504.
tlively added a comment.
- Update tests to check full polymorphism of llvm.memcpy and llvm.memmove
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57736/new/
https://reviews.llvm.org/D57736
Files:
clan
tlively added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29
+// Bulk memory builtins
+TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory")
+TARGET_BUILTIN(__builtin_wasm_data_drop, "vIi", "", "bulk-memory")
tlively updated this revision to Diff 186393.
tlively marked 12 inline comments as done.
tlively added a comment.
- Address comments
- Use `Ui` in builtin signatures
- Remove unnecessary intrinsic polymorphism
- Tweak intrinsic properties
Repository:
rG LLVM Github Monorepo
CHANGES SINC
aheejin added inline comments.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:29
+// Bulk memory builtins
+TARGET_BUILTIN(__builtin_wasm_memory_init, "vIiv*ii", "", "bulk-memory")
+TARGET_BUILTI
tlively created this revision.
tlively added a reviewer: aheejin.
Herald added subscribers: cfe-commits, sunfish, hiraditya, jgravelle-google,
sbc100, dschuff.
Herald added a project: clang.
implements llvm intrinsics and clang intrinsics for
memory.init and data.drop.
Repository:
rG LLVM Git
