rjmccall added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4620
const TargetInfo &TI = Context.getTargetInfo();
- TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC);
+ auto *Aux = Context.getAuxTargetInfo();
+ if (LangOpts.CUDA) {
--
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4620
const TargetInfo &TI = Context.getTargetInfo();
- TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC);
+ auto *Aux = Context.getAuxTargetInfo();
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4620
const TargetInfo &TI = Context.getTargetInfo();
- TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC);
+ auto *Aux = Context.getAuxTargetInfo();
rjmccall added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4620
const TargetInfo &TI = Context.getTargetInfo();
- TargetInfo::CallingConvCheckResult A = TI.checkCallingConvention(CC);
+ auto *Aux = Context.getAuxTargetInfo();
+ if (LangOpts.CUDA) {
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rC354929: [CUDA][HIP] Check calling convention based on
function target (authored by yaxunl, committed by ).
Herald added a project: clang.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://review
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57716/new/
https://reviews.llvm.org/D57716
___
cfe-commits mailing list
cfe-commits@lists.
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57716/new/
https://reviews.llvm.org/D57716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 187943.
yaxunl added a comment.
modify test to use non-template functions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57716/new/
https://reviews.llvm.org/D57716
Files:
lib/Sema/SemaDeclAttr.cpp
test/SemaCUDA/amdgpu-windows-vectorcall.cu
Ind
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: test/SemaCUDA/amdgpu-windows-vectorcall.cu:9-10
+
+template struct A<_Ret (__cdecl
_Arg0::*)(_Types) > { };
+template struct A<_Ret (__vectorcall
_Arg0::*)(_Types) > {};
+
tra wr
tra added inline comments.
Comment at: test/SemaCUDA/amdgpu-windows-vectorcall.cu:3
+
+// expected-no-diagnostics
+template
tra wrote:
> It may be good to add a check where we *would* expect to see the diagnostics.
> It may be good to add a check where we *would*
yaxunl updated this revision to Diff 187862.
yaxunl added a comment.
Herald added a subscriber: jdoerfert.
Revised by Artem's comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57716/new/
https://reviews.llvm.org/D57716
Files:
lib/Sema/SemaDeclAttr.cpp
test/SemaCUDA/amdgpu-win
tra added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:4621-4638
+auto CUDATarget = IdentifyCUDATarget(FD);
+if (CUDATarget == CFT_HostDevice) {
+ A = TI.checkCallingConvention(CC);
+ if (A == TargetInfo::CCCR_OK && Aux)
+A = Aux->checkCallingC
yaxunl updated this revision to Diff 185375.
yaxunl retitled this revision from "Let AMDGPU compile MSVC headers containing
vectorcall" to "[CUDA][HIP] Check calling convention based on function target".
yaxunl edited the summary of this revision.
yaxunl added a reviewer: tra.
yaxunl added a comme
13 matches
Mail list logo
