[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

This revision was automatically updated to reflect the committed changes. Closed by commit rL357027: [clang-format] Add style option AllowShortLambdasOnASingleLine (authored by rdwampler, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added a comment. I don't have commit rights, can someone land this for me or would it be better to try and get commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commit

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 191872. rdwampler added a comment. Rebased on master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2976 + +return Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_None || + Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_Inline || klimek wrote: > If

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 191629. rdwampler marked 2 inline comments as done. rdwampler added a comment. Changes since last revision: -rebased -Fall through when SLS_All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: c

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

klimek added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2976 + +return Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_None || + Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_Inline || If SLS_All is supposed

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added a comment. It might be a good idea to add the nested lambda tests from D44609: [Clang-Format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style) into your review to show how this patch c

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler marked an inline comment as done. rdwampler added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; LLVMStyle.AllowShortLoopsOnASi

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; LLVMStyle.AllowShortLoopsOnASingleLine = false; What

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added a comment. Could you add a line in the docs/ReleaseNotes.rst to say what you are adding CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 187260. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.h

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 185848. rdwampler added a comment. Update to include an option `Inline` to only put short lambda on a single line if used as an argument. See the following code style guide from catboost: ps://github.com/catboost/catboost/blob/master/CPP_STYLE_GUIDE.md#lam

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler created this revision. rdwampler added reviewers: djasper, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option `AllowShortLambdasOnASingleLine` similar to the other `AllowShort*` options, but applied to C++ lambdas. I considered making this depend