[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. In D57649#1382477 , @aaron.ballman wrote: > In D57649#1382470 , @riccibruno > wrote: > > > Though it is a subjective distinction and in the end if someone need a flag > > it is going t

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

aaron.ballman added a comment. In D57649#1382470 , @riccibruno wrote: > Though it is a subjective distinction and in the end if someone need a flag > it is going to be added I guess. That's the crux of how we've decided what information to expose in the

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

This revision was automatically updated to reflect the committed changes. Closed by commit rC353003: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit (authored by brunoricci, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57649/new/

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. Thanks for the review ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57649/new/ https://reviews.llvm.org/D57649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno added a comment. In D57649#1382453 , @steveire wrote: > I have no objection to this, but I wonder whether all state accessible from > all nodes should be part of the AST dump. Where do you think the line is? Is > there anything else missing cu

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

steveire added a comment. I have no objection to this, but I wonder whether all state accessible from all nodes should be part of the AST dump. Where do you think the line is? Is there anything else missing currently from other nodes? Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D57649: [ASTDump] Add a flag indicating whether a CXXThisExpr is implicit

riccibruno created this revision. riccibruno added a reviewer: steveire. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. There is current no way to distinguish implicit from explicit `CXXThisExpr` in the AST dump output. Repository: rC Clang https://reviews.llvm.or