[PATCH] D57590: [ASTImporter] Improve import of FileID.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355000: [ASTImporter] Improve import of FileID. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D57590?vs=184760&id=188553#toc Repository: rC Clang CHANGES S

[PATCH] D57590: [ASTImporter] Improve import of FileID.

balazske added a comment. Currently there is no direct test for `ASTImporter` `FileID` (and other non-Decl) import. These are tested indirectly by other import tests. There is something that fails in a macOS LLDB test without this. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D57590: [ASTImporter] Improve import of FileID.

a_sidorin added a comment. Hi Gabor, Sorry, missed the patch. It looks mostly good, but do we have any test for this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-c

[PATCH] D57590: [ASTImporter] Improve import of FileID.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM I don't see any LLDB test regressions but I would prefer another reviewer as well. I am going to be modifying this soon to fix some issues w/ handling built-ins. Repository: rC Clang

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. In D57590#1411055 , @efriedma wrote: > I don't know anything about this particular patch, but you aren't allowed to > set deadlines like that; the patch review process requires that the patch is > actually reviewed. If you aren'

[PATCH] D57590: [ASTImporter] Improve import of FileID.

efriedma added a comment. I don't know anything about this particular patch, but you aren't allowed to set deadlines like that; the patch review process requires that the patch is actually reviewed. If you aren't getting a response, ask on cfe-dev. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a reviewer: martong. Ping. Please raise your objections if you have any until the 4th of March (that date we are going to commit if there are no objections). Also, please let us know if you find this deadline too strict. Repository: rC Clang CHANGES SI

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. Herald added a subscriber: cfe-commits. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57590/new/ https://reviews.llvm.org/D57590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h