alexfh added a comment.
I wonder whether a list of specific checks (without wildcards) would make more
sense for llvm?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57573/new/
https://reviews.llvm.org/D57573
___
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC352862: Disable tidy checks with too many hits (authored by
ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57573?vs=184714&id=184715#toc
Repository:
rC Clang
CHANGES S
ilya-biryukov updated this revision to Diff 184714.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57573/new/
https://reviews.llvm.org/D57573
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
I'm +1 on disabling these checks as they add too much noise in editors (even
though the naming check is correct, we can't do a global cleanup on the
codebase). Let's commit it, we could revert
ilya-biryukov updated this revision to Diff 184704.
ilya-biryukov added a comment.
- Also disable 'misc-non-private-member-variables-in-classes' in
llvm/.clang-tidy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57573/new/
https://reviews.llvm.org/
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: alexfh.
Herald added projects: clang, LLVM.
Some tidy checks have too many hits in the codebase, making it hard to spot
other results from clang-tidy, therefore rendering the tool less useful.
Two checks were disabled:
- misc-n
