[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. Lost this one after vacation, sorry. Still need to figure out why the test is failing. Any help appreaciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

thakis added a comment. Herald added a subscriber: jdoerfert. ilya-biryukov, ping? :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 ___ cfe-commits mailing l

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Still need to figure out why the test fails and fix it before submitting the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 __

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 185775. ilya-biryukov added a comment. - Simplify code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 Files: clang/test/Index/record-completion-invocation.c

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 185772. ilya-biryukov added a comment. - Move the string to CIndexer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 Files: clang/test/Index/record-completion-

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman added a comment. In D57532#1380383 , @ilya-biryukov wrote: > @arphaman, thanks for pointing this out. It's definitely nice to change stuff > only in one place. > There are two issues still pending: > > - `index-file.cu` still fails, I haven't l

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. @arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place. There are two issues still pending: - `index-file.cu` still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just p

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov updated this revision to Diff 184712. ilya-biryukov added a comment. - Revert "changes to main" - Compute the path in parseTranslationUnit2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 File

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. The real problem is that `clang_parseTranslationUnit2` is broken, so this just fixes one client, `c-index-test`. All other macOS clients that call that function will still be una

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

thakis added a comment. Looking at D54630 , it seems arphaman and dexonsmith are probalby good reviewers for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532 ___

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. I'm not sure who the owners of c-index-test are, so adding people who touched the file recently or might be interested in this landing. Suggestions for other reviewers are **very** welcome. Still struggling to make one test pass: `Index/index-file.cu` fails with:

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov created this revision. ilya-biryukov added reviewers: thakis, ioeric. Herald added a reviewer: EricWF. Herald added subscribers: llvm-commits, arphaman. Herald added a project: clang. Specifically, the version of libc++ that lives alongside the c-index-test binary. After r348365 driv