[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-02-03 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352989: [AST] Extract ASTNodeTraverser class from ASTDumper (authored by steveire, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-02-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// steveire wrote: > I think I'll rename this to `ASTNodeTraverser`. Any objections? Nope,

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-02-01 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:1 +//===--- ASTDumpTraverser.h - Traversal of AST nodes --===// +// I think I'll rename this to `ASTNodeTraverser`. An

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-02-01 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Herald added a project: clang. LGTM with a renaming request. Comment at: include/clang/AST/ASTDumpTraverser.h:83 + + NodeVisitorType &getNodeVisitor() { return

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-31 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 184616. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index: lib/AST/ASTDump

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-31 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:83 + + NodeVisitorType &getNodeVisitor() { return getDerived().doGetNodeVisitor(); } + Derived &getDerived() { return *static_cast(this); } --

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-31 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/ASTDumpTraverser.h:31 + +ASTDumpTraverser traverses the Clang AST for dumping purposes + Missing full stop at the end of the sentence. Comment at: include/clang/AST/ASTDumpTrave

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-30 Thread Stephen Kelly via Phabricator via cfe-commits
steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:63 - if (const auto *C = dyn_cast(D)) -for (const auto *I : C->inits()) - Visit(I); - - if (D->doesThisDeclarationHaveABody()) -Visit(

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-30 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 184363. steveire added a comment. Fix comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

2019-01-30 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jfb. This new traverser class allows clients to re-use the traversal logic which was previously part of ASTDumper. This means that alternative visit logic may be implemented, such as